Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Client 모듈 설정 및 OAuth 관련 RestClient 구현 #7

Merged
merged 4 commits into from
May 2, 2024

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented May 1, 2024

Issue Number

#4

Description

  • Client 모듈 설정
  • Apple 공개키 관련 HttpClient 구현
  • Kakao 공개키 관련 HttpClient 구현
  • Google Id 검증 Bean 등록

Core Code

. . .
	public OidcPublicKeyList getPublicKeys() {
		return webClient.mutate()
			.baseUrl(publicKeyUrl)
			.build()
			.get()
			.retrieve()
			.bodyToMono(OidcPublicKeyList.class)
			.block();
	}
. . .

etc

테스트는 어떤식으로 작성해야 할지 도메인 모델 패턴 관련 영상 시청 후 고민해보겠습니다. 해당 PR의 코드에서 어떤식으로 테스트를 작성할지 방향성을 주셔도 좋습니다.

@lcomment lcomment added chore 빌드 매니저 및 환경 설정 feature 새로운 기능 개발 labels May 1, 2024
@lcomment lcomment requested a review from YongsHub May 1, 2024 15:06
@lcomment lcomment self-assigned this May 1, 2024
Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

dependencies {
implementation project(':cakk-common')

implementation('org.springframework.boot:spring-boot-starter-webflux:3.1.2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webflux를 도입하게 된 이유가 OAuth를 위한 I/O작업 때문에 추가한건가요?
Spring MVC에서 적합한 RestClient를 저는 사용했어서 해당 모듈에서 비동기 Non-Blocking을 위한 리액티브 개발이 필요한 적합한 이유가 궁금하네요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RestClient에 대해 찾아보았더니 현 상황에 더 적합한거 같아 적용했습니다. 최대한 의존성을 줄여보려 했으나 어쩔 수 없이 spring-boot-starter-web을 사용했네요

@lcomment lcomment changed the title Feature: Client 모듈 설정 및 OAuth 관련 HttpClient 구현 Feature: Client 모듈 설정 및 OAuth 관련 RestClient 구현 May 2, 2024
@lcomment lcomment merged commit 67c1bef into master May 2, 2024
@lcomment lcomment deleted the feature/#4 branch May 2, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 빌드 매니저 및 환경 설정 feature 새로운 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants