-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear events before getting key presses in inquiry preview #216
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -286,15 +286,15 @@ | |
"value": "500", | ||
"section": "bci_config", | ||
"readableName": "Task Window Height", | ||
"helpTip": "Specifies the height (in pixels) of the task window when not in full screen mode (Full Screen Mode On/Off must be set to ‘false’). Default: 500", | ||
"helpTip": "Specifies the height (in norm units) of the task window when not in full screen mode (Full Screen Mode On/Off must be set to ‘false’). See https://www.psychopy.org/general/units.html. Default: 500", | ||
"recommended_values": "", | ||
"type": "int" | ||
}, | ||
"window_width": { | ||
"value": "500", | ||
"section": "bci_config", | ||
"readableName": "Task Window Width", | ||
"helpTip": "Specifies the width (in pixels) of the task window when not in full screen mode (Full Screen Mode On/Off must be set to ‘false’). Default: 500", | ||
"helpTip": "Specifies the width (in norm units) of the task window when not in full screen mode (Full Screen Mode On/Off must be set to ‘false’). See https://www.psychopy.org/general/units.html. Default: 500", | ||
"recommended_values": "", | ||
"type": "int" | ||
}, | ||
|
@@ -442,10 +442,10 @@ | |
"type": "str" | ||
}, | ||
"stim_height": { | ||
"value": "0.6", | ||
"value": "0.5", | ||
"section": "bci_config", | ||
"readableName": "Stimulus Size", | ||
"helpTip": "Specifies the height (in ???) of text stimuli. Possible values range from X to X. Default: 0.6", | ||
"helpTip": "Specifies the height of text stimuli. See https://www.psychopy.org/general/units.html. Default: 0.5", | ||
"recommended_values": "", | ||
"type": "float" | ||
}, | ||
|
@@ -532,8 +532,8 @@ | |
"info_height": { | ||
"value": "0.1", | ||
"section": "bci_config", | ||
"readableName": "Text Height", | ||
"helpTip": "Text Height", | ||
"readableName": "Text below main presentation height", | ||
"helpTip": "Specifies the height of iinfo text stimuli. See https://www.psychopy.org/general/units.html. Default: 0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's an extra 'i' in there. |
||
"recommended_values": [ | ||
"0.1" | ||
], | ||
|
@@ -603,7 +603,7 @@ | |
"value": "0.1", | ||
"section": "bci_config", | ||
"readableName": "Task Text Size", | ||
"helpTip": "Specifies the height (in ???) of task-specific text, e.g. #/100 in calibration and target phrase in copy/spelling. Possible values range from 0 to 1. Default: 0.1", | ||
"helpTip": "Specifies the height of task-specific text, e.g. #/100 in calibration and target phrase in copy/spelling. See https://www.psychopy.org/general/units.html. Default: 0.1", | ||
"recommended_values": [ | ||
"0.1" | ||
], | ||
|
@@ -811,13 +811,14 @@ | |
"type": "float" | ||
}, | ||
"preview_inquiry_key_input": { | ||
"value": "space", | ||
"value": "return", | ||
"section": "bci_config", | ||
"readableName": "Preview Inquiry Display Key Input Method", | ||
"helpTip": "Defines the key used to engage with inquiry preview.", | ||
"recommended_values": [ | ||
"space", | ||
"escape" | ||
"escape", | ||
"return" | ||
], | ||
"type": "str" | ||
}, | ||
|
@@ -873,7 +874,7 @@ | |
"value": "0.2", | ||
"section": "feedback_config", | ||
"readableName": "Feedback Stimuli Height", | ||
"helpTip": "Specifies the height of the feedback stimuli. Default: 0.2", | ||
"helpTip": "Specifies the height of the feedback stimuli. See https://www.psychopy.org/general/units.html. Default: 0.2", | ||
"recommended_values": "", | ||
"type": "float" | ||
}, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this was a straightforward fix.