Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: remove empty line from log output #48

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

dsch
Copy link
Contributor

@dsch dsch commented Dec 19, 2024

Log records should not include span over multiple lines.

@henrikbrixandersen
Copy link
Member

Hey! Thank you for your contribution!

Can I ask to to add a message body to your Git commit log? I know it's a minor thing, and I have yet to document the contribution guidelines (or even add automated CI checks for this), but I try to follow the Zephyr coding style and commit requirements as closely as possible.

Rationale for the commit log body is here: https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-body

Remove tailing newline character from the log message.
Logging should not span over multiple lines as it makes
it harder to process automatically.

Signed-off-by: David Schneider <schneidav81@gmail.com>
@dsch dsch force-pushed the fix-empty-log-line branch from e3e62fc to dfcf798 Compare December 20, 2024 10:37
@henrikbrixandersen henrikbrixandersen merged commit 42bbcd1 into CANnectivity:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants