-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yuhsuan/null check tsc silent #2344
Conversation
Revised some fixes by changing the variable types instead of the values. Hope this reduces the possibility of regressions. |
@crocka Thanks for reviewing the changes! Please check my replies and revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No regression from e2e tests. With some other manual tests based on the changed files in the codebase, so far I do not see odd behaviors. Certainly my manual test coverage is not complete, but let's just proceed and see if there are issues from the tests in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BackendService modification has been applied to the MessangeController.ts in the ICD-RxJS repository. (ICD-RxJS branch mylin/modify_MessageController_IBackendResponse)
The ICD-RxJS normal tests and performances tests are all passed without any problem.
Description
This PR is for the first part of #2343. Files in
/utilities
,/models
, and/services
are migrated with the strictNullChecks option enabled.A new script is added to trigger a separate ts compiler with the strcitNullChecks option enabled.
tsc-silent
is applied to suppress errors from files that are not migrated yet.npm run strict-null-checks
. This is also triggered before development and production builds so that developers and the CI are aware of the checks.migratedFiles
list intsc-silent.config.js
.Checklist
For linked issues (if there are):
For the pull request:
changelog updated/ no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
corresponding fix added/new e2e test createdprotobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededBackendService
changed) /no ICD test fix needed (BackendService
unchanged)user manual prepared (for large new features)