feat: code to sample genetic data from input VCF without replacement #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amythewilliams , would it be alright to close this PR now that #194 is merged? |
|
For sure. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion, this code adds the ability to sample individuals/haplotypes from the VCF without replacement. I'm going to make this a draft PR because, as you'll see, there are a few TODOs in comments that I could use your help on. I'm also interested in your thoughts generally on the implementation. If you think it looks good, I can try to convert this to use numpy arrays instead of pandas.
Current required depenedencies: pandas (should be able to remove this)