Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in Github Actions #239

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Build in Github Actions #239

merged 2 commits into from
Feb 6, 2024

Conversation

gycgabriel
Copy link
Collaborator

@gycgabriel gycgabriel commented Feb 6, 2024

Summary:

Currently only have linting, and no testing with Github Actions. To show build errors clearer to PR creators, let's run build in github actions.

Type of change:

(Delete where appropriate)

  • ✨ New Feature/ Enhancement
  • ♻️ CI/CD

Proposed Commit Message:

Let's build in Github Actions to show compile errors clearly.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Copy link
Contributor

@cheehongw cheehongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gycgabriel gycgabriel merged commit a8e9cb9 into main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants