Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preset view only when repo is set #355

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Arif-Khalid
Copy link
Contributor

Summary:

Fixes #352

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Change ngIf behaviour to show preset view and preset view selector only when repo is set

Screenshots:

Before the change when no repo is selected
image
After the change when no repo is selected
image

Proposed Commit Message:

Preset view is shown before a repo is selected.

There is no reason to show the current preset
view and might confuse users as to its purpose
when no repo is selected.

Let's hide the preset view until a repo is selected.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Copy link
Contributor

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arif-Khalid Arif-Khalid merged commit 709afa7 into CATcher-org:main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect-UIX bug Something isn't working category.Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing of preset views before selecting a repo
2 participants