-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error message on incorrect organisation/repo name #378
Enhance error message on incorrect organisation/repo name #378
Conversation
@kokerinks If your PR is ready for review, do mark it as ready so that we can start the review process. |
@nknguyenhc marked as ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nknguyenhc I have made the required changes, feel free to review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user is viewing a repo and changes to an invalid repo,
- Expected behaviour: Error message pops up and user can continue viewing the previous valid repo. This is also the behaviour before this change.
- Actual behaviour: Error message pops up, but the user cannot continue viewing the previous valid repo.
@nknguyenhc Have addressed issues again in latest commits, let me know if there's any other changes to be made! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Fixes #376
Type of change:
Changes Made:
repoOwnerNotPresentMessage
, which will show now when the repo owner (i.e. organisation or username) inOWNER_NAME/REPO
does not existrepositoryNotPresentMessage
insteadScreenshots:
In repo selection page:
After submitting:
Works for other repo-switching functions as well:
Proposed Commit Message:
Checklist: