make use of new mission eh for CBA player eh (#574)

* make use of new mission eh for CBA player eh * make use of new mission eh for CBA player eh * don't delay first execution until after postInit
CBATeam · Jan 13, 2017 · bfbd2da · bfbd2da
1 parent f62a6f9
commit bfbd2da
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 14 deletions.
diff --git a/addons/events/fnc_addPlayerEventHandler.sqf b/addons/events/fnc_addPlayerEventHandler.sqf
@@ -108,10 +108,6 @@ if (_id != -1) then {
 
         GVAR(playerEHInfo) pushBack addMissionEventHandler ["EachFrame", {
             private _player = call CBA_fnc_currentUnit;
-            if !(_player isEqualTo GVAR(oldUnit)) then {
-                [QGVAR(unitEvent), [_player, GVAR(oldUnit)]] call CBA_fnc_localEvent;
-                GVAR(oldUnit) = _player;
-            };
 
             private _data = currentWeapon _player;
             if !(_data isEqualTo GVAR(oldWeapon)) then {
@@ -140,12 +136,6 @@ if (_id != -1) then {
                 };
             };
 
-            _data = vehicle _player;
-            if !(_data isEqualTo GVAR(oldVehicle)) then {
-                GVAR(oldVehicle) = _data;
-                [QGVAR(vehicleEvent), [_player, _data]] call CBA_fnc_localEvent;
-            };
-
             _data = _player call CBA_fnc_turretPath;
             if !(_data isEqualTo GVAR(oldTurret)) then {
                 GVAR(oldTurret) = _data;
@@ -163,13 +153,56 @@ if (_id != -1) then {
                 GVAR(oldCameraView) = _data;
                 [QGVAR(cameraViewEvent), [_player, _data]] call CBA_fnc_localEvent;
             };
+        }];
+
+        GVAR(playerEHInfo) pushBack addMissionEventHandler ["PlayerViewChanged", {
+            private _player = call CBA_fnc_currentUnit;
+
+            if !(_player isEqualTo GVAR(oldUnit)) then {
+                [QGVAR(unitEvent), [_player, GVAR(oldUnit)]] call CBA_fnc_localEvent;
+                GVAR(oldUnit) = _player;
+            };
+
+            private _data = vehicle _player;
+            if !(_data isEqualTo GVAR(oldVehicle)) then {
+                GVAR(oldVehicle) = _data;
+                [QGVAR(vehicleEvent), [_player, _data]] call CBA_fnc_localEvent;
+            };
+        }];
+
+        GVAR(playerEHInfo) pushBack addMissionEventHandler ["Map", {
+            params ["_data"]; //visibleMap is updated one frame later
 
-            _data = visibleMap;
             if !(_data isEqualTo GVAR(oldVisibleMap)) then {
                 GVAR(oldVisibleMap) = _data;
-                [QGVAR(visibleMapEvent), [_player, _data]] call CBA_fnc_localEvent;
+                [QGVAR(visibleMapEvent), [call CBA_fnc_currentUnit, _data]] call CBA_fnc_localEvent;
             };
         }];
+
+        // emulate change to first value from default one frame later
+        // using spawn-dc to not having to wait for postInit to complete
+        0 spawn {
+            {
+                private _player = call CBA_fnc_currentUnit;
+
+                if !(_player isEqualTo GVAR(oldUnit)) then {
+                    [QGVAR(unitEvent), [_player, GVAR(oldUnit)]] call CBA_fnc_localEvent;
+                    GVAR(oldUnit) = _player;
+                };
+
+                private _data = vehicle _player;
+                if !(_data isEqualTo GVAR(oldVehicle)) then {
+                    GVAR(oldVehicle) = _data;
+                    [QGVAR(vehicleEvent), [_player, _data]] call CBA_fnc_localEvent;
+                };
+
+                _data = visibleMap;
+                if !(_data isEqualTo GVAR(oldVisibleMap)) then {
+                    GVAR(oldVisibleMap) = _data;
+                    [QGVAR(visibleMapEvent), [_player, _data]] call CBA_fnc_localEvent;
+                };
+            } call CBA_fnc_directCall;
+        };
     };
 
     GVAR(playerEHInfo) pushBack [_type, _id];

diff --git a/addons/events/fnc_removePlayerEventHandler.sqf b/addons/events/fnc_removePlayerEventHandler.sqf
@@ -57,8 +57,10 @@ default {nil};
 if (!isNil QGVAR(playerEHInfo)) then {
     GVAR(playerEHInfo) deleteAt (GVAR(playerEHInfo) find [_type, _id]);
 
-    if (count GVAR(playerEHInfo) == 1) then {
-        removeMissionEventHandler ["EachFrame", GVAR(playerEHInfo) select 0];
+    if (count GVAR(playerEHInfo) == 3) then {
+        removeMissionEventHandler ["EachFrame",         GVAR(playerEHInfo) select 0];
+        removeMissionEventHandler ["PlayerViewChanged", GVAR(playerEHInfo) select 1];
+        removeMissionEventHandler ["Map",               GVAR(playerEHInfo) select 2];
         GVAR(playerEHInfo) = nil;
     };
 };