Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JR for 1.86 #1023

Merged
merged 2 commits into from
Nov 25, 2018
Merged

Update JR for 1.86 #1023

merged 2 commits into from
Nov 25, 2018

Conversation

robalo
Copy link
Contributor

@robalo robalo commented Nov 14, 2018

Convert ADR-97 rails to JR

@commy2
Copy link
Contributor

commy2 commented Nov 14, 2018

They put it into vanilla?

@commy2 commy2 added this to the 3.9.1 milestone Nov 14, 2018
@jonpas
Copy link
Member

jonpas commented Nov 14, 2018

With next update, yes. Already in RC.

@robalo
Copy link
Contributor Author

robalo commented Nov 14, 2018

Wasn't sure about the muzzle, if I should let it take the 5.56 suppressors, which seems to be common IRL practice on the PS90. Making abstraction of the mount/suppressor compatibility, obviously. So I haven't touched the muzzle config. Thoughts ?

@jonpas
Copy link
Member

jonpas commented Nov 14, 2018

Apparently they can even fit .22 rated suppressors. I am not sure if this is an off case (in which case we could support it) or a general one (in which case we would have to make it more detailed, which isn't worth it).

@Drofseh
Copy link
Contributor

Drofseh commented Nov 15, 2018

.22, 5.56, and 5.7 suppressors would all have the same diameter hole, so the only problems would be how it attaches and if the suppressor is strong enough to container the pressure from the blast.

I wouldn't want to use a suppressor meant for .22LR on a 5.7 or 5.56 gun unless it was robust.

@Kllrt
Copy link
Contributor

Kllrt commented Nov 21, 2018

I think that 7.62x39mm vz58 is missing, also CZ805 with its original magwell can accept only it's own mags and G36 mags, so I am not sure if it's worth forking or just straight up using G36 class.

@dedmen
Copy link
Contributor

dedmen commented Nov 21, 2018

Well do CZ805 magazines also fit into G36? Then I'd say just reuse it.

@Kllrt
Copy link
Contributor

Kllrt commented Nov 21, 2018

This is what I am not sure of, sadly...
(I found some comment under one article, that Bren mags don't work with G36)

@robalo
Copy link
Contributor Author

robalo commented Nov 21, 2018

What do magazines have to do with this PR ? Wrong thread ?

@Kllrt
Copy link
Contributor

Kllrt commented Nov 21, 2018

Dedmen asked me to report is here, sorry if wrong thread.

@dedmen
Copy link
Contributor

dedmen commented Nov 22, 2018

What do magazines have to do with this PR ?

Both are about vanilla :D

@commy2 commy2 merged commit b1fc54c into master Nov 25, 2018
@commy2 commy2 deleted the jr_warlords branch November 25, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants