Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getConfigEntry tweaks #1039

Merged
merged 6 commits into from
Dec 7, 2018
Merged

getConfigEntry tweaks #1039

merged 6 commits into from
Dec 7, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Dec 3, 2018

When merged this pull request will:

  • make function recognize SQF expressions that can be read using getNumber
  • support keyword "STRING" and "TEXT"
  • header fixes
  • standard variable names

@commy2 commy2 mentioned this pull request Dec 3, 2018
Merged
@Dystopian
Copy link
Contributor

Don't you want to remove _return variable and return from switch directly to slightly speedup the function?

@Dystopian
Copy link
Contributor

tested, works good

@PabstMirror @commy2
merging PabstMirror's suggestion
bd3ddbd 
Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2 commy2 added this to the 3.9.1 milestone Dec 7, 2018
@commy2 commy2 merged commit 5a4272b into master Dec 7, 2018
@commy2 commy2 deleted the getConfigEntry-tweaks branch December 7, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux left review comments

@Dystopian Dystopian Dystopian left review comments

@PabstMirror PabstMirror PabstMirror left review comments

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@commy2 @Dystopian @bux @PabstMirror