add default value for CBA_fnc_serializeNamespace #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't test this ingame, but my brain debugger tells me, that this will error in scheduled environment if no or nil default value is proved. 0 spawn {
objNull call CBA_fnc_serializeNamespace;
};-> error undefined variable in expression. This should not error before this PR. |
|
Where can I download this brain debugger!? |
|
@commy2 any suggestions? Having a Don't wanna break the legacy here |
|
Replace
Years of pain and suffering through these exact same issues. |
|
lgtm now |
0 spawn {
a = [] call CBA_fnc_createNamespace;
a setVariable ["a", 1];
a = a call CBA_fnc_serializeNamespace;
a = [a] call CBA_fnc_deserializeNamespace;
private _a = a getVariable "a";
a call CBA_fnc_deleteNamespace;
hint str [a, _a] // [No location,1]
};works |
0 spawn {
a = [] call CBA_fnc_createNamespace;
a setVariable ["a", 1];
a = [a, 0] call CBA_fnc_serializeNamespace;
_a = [a, "a"] call CBA_fnc_hashGet;
_b = [a, "b"] call CBA_fnc_hashGet;
_c = [a, "c", -1] call CBA_fnc_hashGet;
hint str [_a, _b, _c]; // [1,0,-1]
};works |
|
works |
commy2
approved these changes
Jan 18, 2019
commy2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
fnc_serializeVariableI needed this for my mod project since I use this function but was missing the defaultValue I was used to when using
fnc_hashCreate