Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admin macros for usage in strings and config #1048

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jan 25, 2019

When merged this pull request will:

  • currently these cannot be used inside config, because the quote marks are not escaped.
  • after this PR they will escape from strings with single quotes, but I doubt anyone uses them this way

@commy2 commy2 added the Bug Fix label Jan 25, 2019
@commy2 commy2 added this to the 3.10 milestone Jan 25, 2019
@commy2 commy2 merged commit 573cfdd into master Feb 8, 2019
@commy2 commy2 deleted the fix-admin-macros branch February 8, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants