Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache incompatibleClasses at preStart #1053

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Feb 8, 2019

configFile cannot change, so we might aswell collect that stuff at preStart.

@commy2 commy2 added this to the 3.10 milestone Feb 8, 2019
@dedmen
Copy link
Contributor Author

dedmen commented Feb 8, 2019

Measurements are here: #1052 (comment)
TLDR moved about 600ms of load from preInit to preStart.

@dedmen dedmen changed the title WIP: Cache incompatibleClasses at preStart Cache incompatibleClasses at preStart Feb 8, 2019
@commy2 commy2 merged commit 806e7f1 into CBATeam:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants