Move flexiMenu functions to CfgFunctions

[dedmen]

This triggers me.

[commy2]

Could delete these: https://github.com/CBATeam/CBA_A3/blob/master/addons/ui/script_component.hpp#L83-L86

However, before the functions are named cba_flexiMenu_fnc_execute, but now they are named cba_fnc_flexiMenu_execute` etc, or am I missing something?

[dedmen]

Might be right yeah. But then we previously had both
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-d0bf4bd8fc69fef6ce8641586ab5da29L23
cba_flexiMenu_fnc_add and
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-1ed3566cd26e88a81c404dde0895265bR4
cba_fnc_flexuMenu_add

I guess I'll just move them to PREP then?

[commy2]

master:
cba_ui_fnc_execute

PR:
cba_fnc_flexiMenu_execute

[commy2]

see comment

[commy2]

Can we also delete these silly description entries from the other functions? They do nothing.

[commy2]

allVariables missionNamespace

Before minus new (functions lost by this PR):

["cba_ui_fnc_setobjectmenusource"]

New minus old (functions added by this PR):

["cba_fnc_fleximenu_highlightcaretkey","cba_fnc_fleximenu_keydown","cba_fnc_fleximenu_keyup","cba_fnc_fleximenu_list","cba_fnc_fleximenu_mousebuttondown","cba_fnc_fleximenu_getmenudef","cba_fnc_fleximenu_menu","cba_fnc_fleximenu_getmenuoption","cba_fnc_fleximenu_execute","cba_fnc_fleximenu_menushortcut"]

1. Should we add all these new functions?
2. cba_ui_fnc_setobjectmenusource has to be kept.

[dedmen]

wat?
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-d0bf4bd8fc69fef6ce8641586ab5da29R17
It's right there.
And right there https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-1ed3566cd26e88a81c404dde0895265bR12
so what?...

should
https://github.com/CBATeam/CBA_A3/pull/1054/files#diff-d0bf4bd8fc69fef6ce8641586ab5da29R17
be
FUNC(setObjectMenuSource) = CBA_fnc_flexiMenu_setObjectMenuSource; ?

[commy2]

idk, dude, it's the flexi menu dude

[commy2]

What about not doing the = stuff and instead to make use of CfgFunctions with a different tag?
https://community.bistudio.com/wiki/Arma_3_Functions_Library#Tag

[dedmen]

We need some of them twice anyway as they were defined in CfgFunctions and as a PREP with different names.

[commy2]

What I don't want is to introduce new (duplicate) globals with this PR if it can be avoided.