-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve XEH redirect handlers #1056
Conversation
End result of 8 hours of work 700ms CBA_fnc_compileEventHandlers ✔️ 3.67 seconds faster preInit assuming my numbers just add up. Let's see how much difference the preproc roughly takes. Last run was 4.47s preInit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tabs
Is this really worth it though? |
Yes. Very much so. Got roughly a second faster preInit. |
Resolve handlers that just point to a file.
Instead of executing
call compile preprocessFileLineNumbers...
every time before the EH is executed. Detect that pattern and resolve it at compile time and directly compile the target file.Get's rid of (number of preInit scripts in ACE and CBA) calls to preprocessFile and compile at preInit
Get's rid of (number of postInit scripts in ACE and CBA) calls to preprocessFile and compile at postInit
After all the recent PR's to speed up pre/postInit this should give a nice additional boost.
Q: Should I implement that for Object handlers too? I guess yes because everything that uses the call preproc pattern will benefit, which I assume is done for objects too.