Add Magazine Well support for MAAWS #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dahlgren
commented
Feb 18, 2019
| @@ -67,6 +67,12 @@ class CfgMagazineWells { | |||
|
|
|||
| // AT and AA Launchers, ordered lexicographically | |||
| class CBA_Bazooka {}; // M1, M1A1 Bazooka | |||
| class CBA_Carl_Gustaf { // MAAWS, RAWS | |||
There was a problem hiding this comment.
The launcher's real name is "Carl Gustaf Recoilles Rifle", not sure what we should use as class?
https://en.wikipedia.org/wiki/Carl_Gustaf_recoilless_rifle
Perhaps MAAWS is more common?
There was a problem hiding this comment.
I like Carl Gustaf.
MAAWS is a US specific term that none of these other countries use.
https://en.wikipedia.org/wiki/Carl_Gustaf_recoilless_rifle#Users
commy2
approved these changes
Feb 22, 2019
jonpas
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.