Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Help Component #1073

Merged
merged 21 commits into from
Feb 22, 2019
Merged

Refactor Help Component #1073

merged 21 commits into from
Feb 22, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 21, 2019

When merged this pull request will:

  • streamlining / modernizing some code
  • removes random component line from main menu and pause menu
  • insteads shows full list in diary

@commy2 commy2 added the Cleanup label Feb 21, 2019
@commy2 commy2 added this to the 3.10 milestone Feb 21, 2019
@dedmen
Copy link
Contributor

dedmen commented Feb 21, 2019

But I liked the random component line ._.
Who looks into diary, like ever?

@commy2
Copy link
Contributor Author

commy2 commented Feb 21, 2019

I restored some commented out diary entries (with updated links).

Wiki

https://i.imgur.com/nsXfiew.png

Bugtracker

https://i.imgur.com/RbOyIqz.png

Credits

https://i.imgur.com/ZCZMEtd.png

Credits is basically the same as the main menu random component line and I like the full list (that is less in your face) more.

I think Bugtracker and Wiki are superfluous. And you can't have clickable links in the diary. Should they be removed entirely?

Keybinding is the same, except that I deleted a few newlines at the end of the entry, so the spacing looks prettier.

@jonpas
Copy link
Member

jonpas commented Feb 21, 2019

I thought diary supports HTML including links?

Bug tracker and wiki could stay, but maybe under a single header, not two.

@commy2
Copy link
Contributor Author

commy2 commented Feb 21, 2019

It's fake HTML with different tags:
https://community.bistudio.com/wiki/createDiaryRecord

@commy2
Copy link
Contributor Author

commy2 commented Feb 22, 2019

ACE and CBA

https://i.imgur.com/mLCycR8.png
https://i.imgur.com/dX3IcHq.png
https://i.imgur.com/ItsyOzA.png

Note that ace - etc. will be displayed as @ace for most people, since it is the folder name of the addon.

@PabstMirror PabstMirror changed the title Help Refactor Help Component Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants