Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #1082 - leave states on delete #1085

Closed

Conversation

Fusselwurm
Copy link
Contributor

@Fusselwurm Fusselwurm commented Feb 28, 2019

When merged this pull request will:

Let a state machine's items leave their states when the machine gets deleted by executing their onStateLeave handler.
This mirrors the behavior when creating a state machine, where the initial state's onStateEntered handler is called without a transition.

(edit: correction, not necessary for #1082 )

TODO

  • test
  • squash

@Fusselwurm Fusselwurm changed the title ref #10820 - leave states on delete ref #1082 - leave states on delete Feb 28, 2019
@commy2
Copy link
Contributor

commy2 commented Feb 28, 2019

Draft

wtf

@jonpas
Copy link
Member

jonpas commented Feb 28, 2019

wtf

https://github.blog/2019-02-14-introducing-draft-pull-requests/

@commy2 commy2 added the WIP label Mar 7, 2019
@commy2 commy2 added this to the Backlog milestone Mar 7, 2019
@Fusselwurm Fusselwurm closed this May 28, 2021
@Fusselwurm Fusselwurm deleted the clean-up-states-on-delete branch May 28, 2021 19:37
@commy2
Copy link
Contributor

commy2 commented May 28, 2021

Why close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants