Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings, fix set for out of bounds priority #1092

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 8, 2019

When merged this pull request will:

  • fix a freeze for invalid priority used in FUNC(set).
["banana", "CHECKBOX", "Banana", "Banana", true] call CBA_settings_fnc_init;
["banana", true, 3] call CBA_settings_fnc_set;

Before PR: game freeze, after PR: undefined behavior.

@commy2 commy2 added the Bug Fix label Mar 8, 2019
@commy2 commy2 added this to the 3.10.1 milestone Mar 8, 2019
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This macro is getting uglier and uglier...

@commy2
Copy link
Contributor Author

commy2 commented Mar 9, 2019

That's good, because it is used like 7 times in the scripts, and they can all stay as they are.

@commy2 commy2 modified the milestones: 3.10.1, 3.10 Mar 9, 2019
@commy2 commy2 merged commit ad20266 into master Mar 9, 2019
@commy2 commy2 deleted the settings-fix-lockup-invalid-priority branch March 9, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants