fix error popup in Arsenal Garage #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Mar 9, 2019
| @@ -2,15 +2,13 @@ class CfgMods { | |||
| class PREFIX { | |||
| author = "$STR_CBA_Author"; | |||
| dir = "@CBA_A3"; | |||
| name = "Community Base Addons v3.9.1"; | |||
There was a problem hiding this comment.
change it to 0.0.0
there is code to change on build
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L77
versionFiles = ["mod.cpp","addons\main_a3\CfgMods.hpp"]
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L597
There was a problem hiding this comment.
Suggested change
| name = "Community Base Addons v3.9.1"; | |
| name = "Community Base Addons v0.0.0"; |
Like this?
There was a problem hiding this comment.
yeah, also need to change
https://github.com/CBATeam/CBA_A3/blob/master/tools/make.py#L77
versionFiles = ["mod.cpp","addons\main_a3\CfgMods.hpp"]
|
@PabstMirror Merge? |
jonpas
reviewed
Mar 9, 2019
| picture = "x\cba\addons\main\logo_cba_ca.paa"; | ||
| hidePicture = 1; | ||
| hideName = 1; | ||
| actionName = "Website"; | ||
| action = "$STR_CBA_URL"; | ||
| description = "Bugtracker: https://github.com/CBATeam/CBA_A3/issues<br/>Documentation: https://github.com/CBATeam/CBA_A3/wiki"; | ||
| logo = "logo_cba_ca.paa"; |
There was a problem hiding this comment.
This works if you have the logo inside a PBO as well, not just root of @mod folder.
PabstMirror
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Picture logo_cba_ca.paa not foundwhen opening the Virtual GaragescopeArsenal = 0;Predictably
scopeArsenal = 0;doesn't work. It never works. I just leave it here as a reminder for everyone else thatscopeArsenalindeed does not work.