Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep Editor in local hosted mission browser while hiding stock missions #1099

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 16, 2019

When merged this pull request will:

  • Currently, in local hosted MP only, you can select a special editor "mission" to open MP 3den. In MP 3den when using the preview the lobby opens and connected clients can pick slots. Very helpful for debugging btw.
  • With the addition of the stock mission filter when filtering stock missions this entry will be hidden from the list, despite not being a stock mission technically.
  • Since a way to open the editor is pretty much the opposite of using a stock mission, I want to keep this entry even when the filter is active.
  • The reason it becomes hidden is because the list box entry has value "" instead of "missionName.mapName". "" splitString "." is the empty array. [] select 0 is nil, no error. ARRAY find nil is nil and thus the if executes neither the then nor the else block. Basically something that errors in scheduled environment.
  • switching to param with default value makes my script recognize the mission name of the editor "mission" as "" instead of undefined, and thus it is correctly recognized as not a stock mission.

@commy2 commy2 added the Bug Fix label Mar 16, 2019
@commy2 commy2 added this to the 3.10.1 milestone Mar 16, 2019
@commy2 commy2 merged commit 1082b02 into master Mar 16, 2019
@commy2 commy2 deleted the fixFilter branch March 16, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants