Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More WW2 era magwells #1104

Merged
merged 1 commit into from
Apr 7, 2019
Merged

More WW2 era magwells #1104

merged 1 commit into from
Apr 7, 2019

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Mar 31, 2019

When merged this pull request will:

  • Add more WW2 era magwells to support CSA38 and September 39
  • Add a couple other random missing ones
  • Expand some comments to be more specific
  • Increase whitespace after magwell includes because magwells_8x50mmR_Mannlicher.hpp is such a long name

dedmen
dedmen approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwO so many different magazine

@Drofseh
Copy link
Contributor Author

Drofseh commented Mar 31, 2019

Indeed, no STANAG magwells at the time.

@commy2
Copy link
Contributor

commy2 commented Mar 31, 2019

Comments behind the lines were a mistake. Now it created a pink wall.

@commy2
Copy link
Contributor

commy2 commented Mar 31, 2019

@Drofseh Did you delete or rename any classes?

@Drofseh
Copy link
Contributor Author

Drofseh commented Mar 31, 2019

No classnames were changed.

@commy2
Copy link
Contributor

commy2 commented Mar 31, 2019

Yeah, didn't see any. Only additions as it should be. But I asked just to make sure I didn't miss anything in the pink wall.

@commy2 commy2 added this to the 3.11 milestone Mar 31, 2019
@commy2 commy2 modified the milestones: 3.11, 3.10.2 Apr 7, 2019
@commy2 commy2 merged commit 87c4e07 into CBATeam:master Apr 7, 2019
@commy2 commy2 modified the milestones: 3.10.2, 3.11 Apr 7, 2019
@Drofseh Drofseh deleted the WW2-Magwell-Additions branch May 31, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen approved these changes

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Drofseh @commy2 @dedmen