Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CBA_fnc_addSetting #1111

Merged
merged 1 commit into from
Apr 7, 2019
Merged

add CBA_fnc_addSetting #1111

merged 1 commit into from
Apr 7, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 6, 2019

When merged this pull request will:

  • CBA_fnc_addSettings is defined by CfgFunctions, cba_settings_fnc_init by PREP.
  • This means that cba_settings_fnc_init will be undefined when used by an addon in preInit that does not require cba_settings and is therefore likely loaded before the settings XEH preInit can define the function.
  • CBA_fnc_addSettings reads the function from the ui namespace cache and therefore gets around the requirement of putting cba_settings into requiredAddons of the mod that wants to add a setting.

@commy2 commy2 added this to the 3.10.2 milestone Apr 6, 2019
@commy2 commy2 changed the title add CBA_fnc_addSettings add CBA_fnc_addSetting Apr 6, 2019
@commy2 commy2 merged commit 958b2e6 into master Apr 7, 2019
@commy2 commy2 deleted the addSetting branch April 7, 2019 07:01
@commy2 commy2 modified the milestones: 3.10.2, 3.11 Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants