2D Optics polish translation #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
approved these changes
Apr 7, 2019
commy2
added a commit
that referenced
this pull request
Apr 13, 2019
* add 2d optics component * assets * port some functions * add component to main requiredAddons, fix currentOptic for null * port CBA_fnc_restartCamera, some macros * port updateOpticInfo, global variable names, setting * punctuation * some global variables * loadScriptedOptic and animateScriptedOptic functions * work on changePIP/CarryHandleOpticClass functions * work on changePIP/CarryHandleOpticClass functions * fix bugs * Update addons/2doptics/reticles/pip.rvmat Co-Authored-By: commy2 <commy-2@gmx.de> * fix a function description * move stuff to ace * Thanks Travis * optimize, don't create camera if pip disabled * optimize * delete empty file * new configs * multiple carry handle types support * fix a classname in config * shortened classnames * delete unused macros * fix a bug * add dummy classes to force magnification * 2D Optics polish translation (#1113) * setOpticMagnification function * fix various bugs and quirks * restore optic magnification after optic mode toggle wip * restore magnification and zeroing * pip support for launchers and pistols * restore magnification for pistol and launcher optics * spelling "collimator" * cache zeroing distances array on optic switch * add support for scripted optics mode pp effects * fix flickering of current zeroing in ui when switching modes * delete dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: