Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JR - Fix suppressor file path changes in 1.92 #1131

Merged
merged 1 commit into from
May 1, 2019
Merged

Conversation

PabstMirror
Copy link
Contributor

pictures changed in 1.92
it's defined fine in vanilla configs

@PabstMirror PabstMirror added this to the 3.10.2 milestone Apr 30, 2019
@commy2 commy2 modified the milestones: 3.10.2, 3.11 Apr 30, 2019
@commy2 commy2 merged commit 557c135 into master May 1, 2019
@commy2 commy2 deleted the fixSuppresserPics branch May 1, 2019 03:46
@dedmen
Copy link
Contributor

dedmen commented May 2, 2019

Now our black and green silencers have the same picture? That can't be right.

@PabstMirror
Copy link
Contributor Author

vanilla configs are

class muzzle_snds_H_MG_blk_F: muzzle_snds_H_MG {
    picture = "\a3\Weapons_F_Exp\Acc\Data\UI\icon_muzzle_snds_H_MG_blk_F_ca.paa";
class muzzle_snds_H_MG_khk_F: muzzle_snds_H_MG {
    picture = "\a3\Weapons_F_Exp\Acc\Data\UI\icon_muzzle_snds_H_MG_khk_F_ca.paa";

and those are different images

@dedmen
Copy link
Contributor

dedmen commented May 2, 2019

Ah we edit, not create that class.
Why do we change the model? atleast for muzzle_snds_H_MG_blk_F we have the same as vanilla.
Also the vanilla name seems to be "Sound suppressor MG" which is same as ours.
What do we even do here?
We don't change the model, we don't change the name, we don't change the picture.

@commy2
Copy link
Contributor

commy2 commented May 2, 2019

Good questions. I think we may have once added these unused textures and names or something, but now BI does use them themselves. Should probably all be deleted.

@PabstMirror
Copy link
Contributor Author

vanilla models are different (I think they were either shorter or longer) but looked fine to me

@robalo
Copy link
Contributor

robalo commented May 2, 2019

When I added the MG suppressor classes to JR the vanilla ones were hidden and used either the 7.62 SCAR-H model or the 5.56 one. IMO the .338 model looks a lot more like an MG suppressor than any of those.

Copy link
Contributor

@robalo robalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct ones:
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_sand_ca.paa";
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_black_ca.paa";
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_green_ca.paa";

@robalo
Copy link
Contributor

robalo commented May 2, 2019

Good questions. I think we may have once added these unused textures and names or something, but now BI does use them themselves. Should probably all be deleted.

Nope, they're still hidden, the only issue was picture path has changed in 1.92 for the .338 suppressors which we use as MG suppressors.

@commy2
Copy link
Contributor

commy2 commented May 2, 2019

So everything is alright and works as expected here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants