-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JR - Fix suppressor file path changes in 1.92 #1131
Conversation
Now our black and green silencers have the same picture? That can't be right. |
vanilla configs are
and those are different images |
Ah we edit, not create that class. |
Good questions. I think we may have once added these unused textures and names or something, but now BI does use them themselves. Should probably all be deleted. |
vanilla models are different (I think they were either shorter or longer) but looked fine to me |
When I added the MG suppressor classes to JR the vanilla ones were hidden and used either the 7.62 SCAR-H model or the 5.56 one. IMO the .338 model looks a lot more like an MG suppressor than any of those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct ones:
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_sand_ca.paa";
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_black_ca.paa";
picture = "\a3\Weapons_F_Mark\Data\UI\icon_muzzle_snds_338_green_ca.paa";
Nope, they're still hidden, the only issue was picture path has changed in 1.92 for the .338 suppressors which we use as MG suppressors. |
So everything is alright and works as expected here? |
pictures changed in 1.92
it's defined fine in vanilla configs