Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fail to read settings from settings file #1134

Merged
merged 2 commits into from
May 3, 2019
Merged

fix fail to read settings from settings file #1134

merged 2 commits into from
May 3, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 3, 2019

When merged this pull request will:

  • title
  • bug is old, but only circumstances reveal it in 3.11.0 with CBA only
  • Thanks to cyruz, diwako, max255pl and whoever I forgot for helping with debugging and thanks for reporting ofc :P

@commy2 commy2 added the Bug Fix label May 3, 2019
@commy2 commy2 added this to the 3.11.1 milestone May 3, 2019
@diwako
Copy link

diwako commented May 3, 2019

Tested on dedicated linux server. Server enforced settings for ACE and ACRE2 during the test as expected from the cba_settings.sqf file in a PBO loaded on server.

jonpas
jonpas approved these changes May 3, 2019
View reviewed changes
addons/settings/fnc_addSetting.sqf Show resolved Hide resolved
@commy2 commy2 merged commit d463421 into master May 3, 2019
@commy2 commy2 deleted the settings-v3.11-debugging branch May 3, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @diwako @jonpas