Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Curator and 3DEN cargo attributes #1140

Merged
merged 4 commits into from
May 8, 2019
Merged

fix Curator and 3DEN cargo attributes #1140

merged 4 commits into from
May 8, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 8, 2019

When merged this pull request will:

BI changed some things in the functions that compile these lists (alphabetical sorting, magwells, swapped display name and class name), so we have to adjust or it doesn't show or misses items.

@commy2 commy2 added this to the 3.11.2 milestone May 8, 2019
@commy2
Copy link
Contributor Author

commy2 commented May 8, 2019

Done. Tests are a beautiful thing.

16:14:25 [CBA] (ui) Test OK: (cba_ui_fnc_preload3DEN is defined) x\cba\addons\ui\test_preload.sqf:11
16:14:29 [CBA] (ui) Test OK: ([_vanilla] isEqualTo [_cba]) x\cba\addons\ui\test_preload.sqf:28
16:14:29 [CBA] (ui) Test OK: (cba_ui_fnc_preloadCurator is defined) x\cba\addons\ui\test_preload.sqf:34
16:14:32 [CBA] (ui) Test OK: ([_vanilla] isEqualTo [_cba]) x\cba\addons\ui\test_preload.sqf:57

May need to #define DEBUG_MODE_FULL for the test to return correct results, because vanilla lists any public CfgVehicles subclass as compatible backpack (lol), which is optimized away for us outside of debug mode for this test only.

Ignore

private _index = _classes find _class;
private _value = i>
16:14:27   Error position: <_classes find _class;
private _value = i>
16:14:27   Error Undefined variable in expression: _classes
16:14:27 File A3\3den\UI\attributes\AmmoBox.sqf, line 328
16:14:27 Error in expression <classes", "_values"];

Error pop up during test. It is the game trying to read the cargo of the currently selected 3den entity, but some command reports nil for null. Is just for the ui refresh and the test has no ui anyway.

@commy2 commy2 removed the WIP label May 8, 2019
@dedmen
Copy link
Contributor

dedmen commented May 8, 2019

firefox_2019-05-08_16-35-36
wat are u doing.

I can predict the future!
firefox_2019-05-08_16-36-26

@commy2 commy2 merged commit 8a559b3 into master May 8, 2019
@commy2 commy2 deleted the fix-preloadCargo branch May 8, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeus cannot edit supply crates
3 participants