Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace %20 with space when displaying mission name #1150

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 24, 2019

When merged this pull request will:

  • Replaces %20 in the mission name with spaces on mission select screen, lobby, briefing and map.

@commy2 commy2 added this to the 3.12 milestone May 24, 2019
for "_i" from 0 to (lbSize _ctrlMissions - 1) do {
private _name = _ctrlMissions lbText _i;
private _name = [_ctrlMissions lbText _i, "%20", " "] call _fnc_replace; // replace %20 with space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like _fnc_replace is bad name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How so? It is CBA_fnc_replace fetched from ui namespace in case the host started the game with -world=empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry I just missed assigning line 😕 🤦‍♂️

@PabstMirror PabstMirror changed the title replace %20 with space Replace %20 with space when displaying mission name May 27, 2019
@commy2 commy2 merged commit c25bd18 into master Jun 3, 2019
@commy2 commy2 deleted the remove%20 branch June 3, 2019 22:11
@commy2
Copy link
Contributor Author

commy2 commented Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants