fix updating flashlight fx after attachment switch

[tbeswick96]

When merged this pull request will:

• Move adding of next attachment to next frame
• Move switched localEvent to next frame (after add**Item)
• Allows different flashlight modes to be used and update properly when switching
• Currently switching from one flashlight to another in the same frame whilst the flashlight is on causes the light effect not to update to the new flashlight

[tbeswick96]

Video to show:
https://www.youtube.com/watch?v=AgkcpN-At0Q

Shows normal flashlight on, switching to far causes no effect change.
Switching to far then off then on causes effect change.

ExecNextFrame forces the effect to refresh

[dedmen]

switching from one flashlight to another in the same frame whilst the flashlight is on causes the light effect not to update to the new flashlight

ugh.. Arma.

Near/Far flashlight is a nice idea, is your mod for that public or do you play to propose that to ACE?

[dedmen]

I don't like the use of # and the missing spacing around it, and the missing naming inside the piece of code.
But it's just a one liner and it's really obvious what's happening so it doesn't matter.

[tbeswick96]

Wasn't planning on making the far flashlights part of ace, I lumped them onto a 3CB flashlight/ir combo

Any thoughts on the localEvent?

[dedmen]

Any thoughts on the localEvent?

Oops missed that. I think it should. People may use it to re-replace the item or detach it or whatever. Would be weird if it's not there yet.

[tbeswick96]

@dedmen Do you think this is ok? https://github.com/CBATeam/CBA_A3/pull/1154/files#diff-73655685f2cbb36065c6caf471ec6630R75
Should run after the adds as it's added after right?

[dedmen]

Also the event says "switched" in past tense. So it has to fire after.
Yes, nextFrame EH's run in order they were added.

[commy2]

Currently switching from one flashlight to another in the same frame whilst the flashlight is on causes the light effect not to update to the new flashlight

I don't get it. The same frame as what else exactly? The flashlight being on? Is the flashlight being turned off anywhere here?

[tbeswick96]

Switching in this context means removing one attachment and adding another. When both of the attachments are flashlights and the flashlight is on, the light effect of the new flashlight does not update unless you manually turn the light off and on after switching. This is because the remove and add are done in the same frame

[commy2]

What happens if you hold down the key with this change? (switch attachment every frame. multiple times per frame)?

Should be possible I guess, because the current attachment is removed immediately, but would test anyway.

[tbeswick96]

Holding the key down just switches once