Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend 3den selectable date range from 1900 to 2050 #1155

Merged
merged 6 commits into from
Jun 7, 2019

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Jun 3, 2019

When merged this pull request will:

  • This will allow missions makers to set a date in 3den from 1900 to 2050.
    By default 3den only allows a selectable date range from 1982 to 2050
  • This will significantly improve the QOL for those making mission in the WW2, Vietnam, or other non-modern eras.

addons/common/config.cpp Outdated Show resolved Hide resolved
addons/common/Cfg3DEN.hpp Outdated Show resolved Hide resolved
addons/common/Cfg3DEN.hpp Outdated Show resolved Hide resolved
@Drofseh
Copy link
Contributor Author

Drofseh commented Jun 3, 2019

Thanks for the suggestions @commy2, I'll implement them.

Would "A3_Data_F_Exp_B_Loadorder" be good to add to requiredAddons[]?
It in turn requires "A3_3DEN","A3_3DEN_Language","A3_Data_F_Exp_B","A3_Language_F_Exp_B"

@Drofseh Drofseh changed the title Extend 3den selectable date range from 1900 to 2050 [WIP] Extend 3den selectable date range from 1900 to 2050 Jun 3, 2019
@commy2
Copy link
Contributor

commy2 commented Jun 3, 2019

common is already requiring Loadorder Tanks, which requires Loarorder ExpB iirc.

@Drofseh
Copy link
Contributor Author

Drofseh commented Jun 3, 2019

A3_3DEN is the one that's really required for this

@commy2
Copy link
Contributor

commy2 commented Jun 3, 2019

Yes, and LO ExpB requires A3_3DEN, which means that Tanks requires 3DEN implicitly as well already, and so does common.

@Drofseh Drofseh changed the title [WIP] Extend 3den selectable date range from 1900 to 2050 Extend 3den selectable date range from 1900 to 2050 Jun 3, 2019
@Drofseh
Copy link
Contributor Author

Drofseh commented Jun 3, 2019

Alright, I'm happy with it if you are.

@commy2
Copy link
Contributor

commy2 commented Jun 3, 2019

This change should go along with adding the years to ModuleDate_F.
However, adding values to arguments in modules out of order may break modules placed without CBA / before CBA, because the value is referenced by config index and if you set 1982 in vanilla (index 0) and then load this patch, it might become 1900, because that is the new first value with index 0.

... iirc

@Drofseh
Copy link
Contributor Author

Drofseh commented Jun 3, 2019

Yah, updating ModuleDate_F looks like it will break things to me.

Details
	class ModuleDate_F: Module_F
	{
		author="$STR_A3_Bohemia_Interactive";
		_generalMacro="ModuleDate_F";
		scope=2;
		displayName="$STR_A3_CfgVehicles_ModuleDate_F_0";
		category="Events";
		function="BIS_fnc_moduleDate";
		isGlobal=1;
		isTriggerActivated=1;
		class Arguments
		{
			class Year
			{
				displayName="$STR_A3_CfgVehicles_ModuleDate_F_Arguments_Year_0";
				description="";
				class values
				{
					class NoChange
					{
						name="$STR_DISP_OPT_NOCHANGE";
						value=-1;
						default=1;
					};
					class Number1982
					{
						name="1982";
						value=1982;
					};
					class Number1983
					{
						name="1983";
						value=1983;
					};
					class Number1984
					{
						name="1984";
						value=1984;
					};
					//etc.

@commy2
Copy link
Contributor

commy2 commented Jun 3, 2019

But changing only one seems awkward to me :S

@jonpas
Copy link
Member

jonpas commented Jun 3, 2019

Eden should be used instead of modules anyways. If changing the module breaks something, leave it out.

@commy2 commy2 added this to the 3.12 milestone Jun 7, 2019
@commy2 commy2 self-assigned this Jun 7, 2019
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but please delete the empty line before merge

Co-Authored-By: commy2 <commy-2@gmx.de>
addons/common/Cfg3DEN.hpp Outdated Show resolved Hide resolved
Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2 commy2 merged commit 79773f1 into CBATeam:master Jun 7, 2019
@Drofseh Drofseh deleted the editor-date-range branch July 15, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants