update CBA_fnc_uniqueUnitItems

[commy2]

When merged this pull request will:

• close magazines not attached to weapons in use are omitted from CBA_fnc_uniqueUnitItems #1156
• added _magazines flag, default false. Unless set to true, no mags will be reported (even with _weaponItems set to true)
• _magazines flag will not report loaded mags unless _weaponItems flag is also set to true.
• added note why binocular command is not needed (covered by assignedItems)
• no longer reports empty string
• formatting

[dedmen]

Might be cheaper to do it at the end, after duplicate removal.
because - iterates over everything and copies everything.

[dedmen]

Or if we know where it comes from (I guess primary/secondary/handgunWeapon) we can do it right there.
Would be cheaper to do in L58 for just the 3 things, than do it for everything.

[commy2]

It comes from p/s/hWeapon as well as p/s/hWeaponItems. The magazine commands report empty arrays if no mag is loaded. I put the array subtraction below the last line that may add empty strings. CBA_fnc_binocularMagazine reports empty string too.

The placement is so that the array subtraction command is only executed when the _weaponItems flag is set, as this is the only place where the commands may add empty strings. Note that while p/s/hWeaponItems has the items in order muzzle/pointer/optics/bipod and fills the gaps with empty strings, assignedItems, while having an order, just changes in array size (and indices) if a specific slot is unoccupied.

If I were to add it to the last line after the arrayIntersect command instead, I would slow down the function for every use even when this flag is set to false. I know that a smaller array would speed up the function slightly, but this would mean adding an additional binary command (-) for all uses for a small improvement in C++ that itself wouldn't even be a problem in all other use cases. The priority is clear to me.

The only potential optimization here would be moving the weapon(items/magazines) block above the uniform/vest/backpack block.

[commy2]

Another potential optimization approach would be creating the initial array as [""] and then using pushBackUnique everywhere. And then using deleteAt 0 at the end. However, this would need appendUnique, because one source of empty strings are arrays here.

[dedmen]

Maybe instead store _weaponItems seperately, then remove "" from it.
And only then append it to _allItems. That way you don't have to iterate over uniform/vest/backpack items to remove ""

and then using pushBackUnique everywhere

Nah not with the number of appends we have.

[dedmen]

Make a new array here
https://github.com/CBATeam/CBA_A3/pull/1157/files#diff-5281788de7c6251ec13f252782a5e72fR54
And then _allItems append _newArray after removing the ""

[commy2]

That would mean more commands in total. I don't think there will be any case where this actually would be faster.

[dedmen]

but only in the weaponsItems case
which I'd say is rare.