Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle expressions in CfgOpticsEffect #1165

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jun 17, 2019

When merged this pull request will:

  • Convert strings to numbers, so the command doesn't error.

Found this yesterday when testing CBA master with my unit. Related to #1163.

@commy2 commy2 added the Bug Fix label Jun 17, 2019
@commy2 commy2 added this to the 3.12 milestone Jun 17, 2019
@commy2
Copy link
Contributor Author

commy2 commented Jun 19, 2019

  • Test this on the 5:4 TFT to see if the 16/9 in height can be replaced by getResolution.

@commy2 commy2 merged commit 57f542e into master Jun 20, 2019
@commy2 commy2 deleted the fix-opticEffects-string branch June 20, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants