Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.94 - Fix GL magwells #1183

Merged
merged 4 commits into from
Jul 26, 2019
Merged

1.94 - Fix GL magwells #1183

merged 4 commits into from
Jul 26, 2019

Conversation

PabstMirror
Copy link
Contributor

Added: magazineWells to Underbarrel Grenade Launchers

New vanilla configs:

    class UGL_F: GrenadeLauncher {
        magazineWell[] = {"UGL_40x36"};
        
    class arifle_MX_GL_F: arifle_MX_Base_F {
        class GL_3GL_F: UGL_F {
                magazineWell[] = {"UGL_40x36","3UGL_40x36"};

This just uses = instead of += because of problems with inhetiance
The proper way would be to add a subconfig: 8e24cb6
but not sure if we want to add another cfgPatch just for something minor?

@PabstMirror PabstMirror added the 1.94 Contact DLC label Jul 25, 2019
@commy2 commy2 added this to the 3.12.1 milestone Jul 25, 2019
@commy2 commy2 added the Task label Jul 25, 2019
@commy2
Copy link
Contributor

commy2 commented Jul 25, 2019

JR has a prep component and I cut that down to be a very basic sub component. I don't really understand why it is needed here though.

@CBATeam CBATeam deleted a comment from PabstMirror Jul 25, 2019
@commy2
Copy link
Contributor

commy2 commented Jul 25, 2019

It is exactly as you wrote, Pabst. I went with what you suggested, because another config is fine for this imo as it is needed by limitation of +=.

I went with "finish" as the opposite of "preperation" (used in JR and UI).

Merge?

@PabstMirror
Copy link
Contributor Author

🇫🇮 lgtm

@commy2 commy2 merged commit 5fd88fa into master Jul 26, 2019
@commy2 commy2 deleted the fixGlWells1 branch July 26, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.94 Contact DLC Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants