-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement addWeaponWithAttachmentsCargoGlobal command #1188
Conversation
Also needs to be done for |
You mean your functions? |
Yeah, just reminder. |
This comment has been minimized.
This comment has been minimized.
Test passes now after I fixed things. |
@@ -115,7 +115,7 @@ _container addBackpackCargoGlobal ["B_AssaultPack_mcamo", 1]; | |||
((everyBackpack _container) select 0) addWeaponCargoGlobal ["arifle_MX_ACO_pointer_F", 1]; | |||
_result = [_container, "B_AssaultPack_mcamo", 1, true] call CBA_fnc_removeBackpackCargo; | |||
TEST_TRUE(_result,_funcName); | |||
TEST_TRUE(count (backpackCargo _container) == 0 && count (weaponCargo _container) == 1 && count (itemCargo _container) == 2,_funcName); | |||
TEST_TRUE(count (backpackCargo _container) == 0 && count (weaponCargo _container) == 1 && count (itemCargo _container) == 0,_funcName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is different from the previous one in that it keeps the attachments. But since AWWACG adds the attachments to the weapon instead of the cargo, both tests have count itemCargo == 0.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
When merged this pull request will:
This means mags and attachments are now on the dropped weapon, and rare classes with preconfigured attachments don't create those attachments out of thin air anymore when they were removed before the weapon was dropped.