Add Lobby Manager #1194
Add Lobby Manager #1194
Conversation
…into slotlist-manager
This reverts commit 9bad948.
|
Very happy someone is working on it :) thanks @mharis001 |
addons/ui/fnc_openLobbyManager.sqf
Outdated
| set3DENSelected [_group]; | ||
|
|
||
| private _handle = 0 spawn {do3DENAction "CutUnit"}; | ||
| waitUntil {scriptDone _handle}; |
There was a problem hiding this comment.
Can you explain what this is doing?
There was a problem hiding this comment.
Delaying the 3DEN actions by a frame (at least) and then resuming after they occur.
There was a problem hiding this comment.
I see. spawn takes at least one frame, so the following waitUntil waits for at least one frame.
Could still be rewritten in unscheduled with some stacked execNextFrame decrementing some array. Idk what that would add besides proving a point, ... so I will probably do that.
There was a problem hiding this comment.
I thought execNextFrame was not available in 3DEN, that is why I used scheduled.
There was a problem hiding this comment.
to delay one frame you could also just make the waitUntil return false once. But I guess the code for that would atleast look more complicated.
There was a problem hiding this comment.
I thought execNextFrame was not available in 3DEN, that is why I used scheduled.
Yeah. Could add a RscMapControl with Draw eh as each frame engine though. Anything to avoid waitUntil and spawn. lol
There was a problem hiding this comment.
If we check for bad code we always search for spawn but rarely for waitUntil. Just hide the spawn and noone will know ;)
There was a problem hiding this comment.
Oh. Didn't see second spawn above.
addons/ui/fnc_openLobbyManager.sqf
Outdated
| } forEach _groups; | ||
|
|
||
| set3DENSelected _selected; | ||
| endLoadingScreen; |
There was a problem hiding this comment.
This ends all loading screens. might theoretically happen that other mods start other loadingscreens inbetween while your scheduled code runs. Though it's unlikely.
|
No, I'd rather have you bickering about it not being released than it being broken, because I don't have to maintain unreleased stuff. |
|
What is the threshold we are going for? I just ran through 50 consecutive successful tests changing both group and unit order and then testing in local MP each time. I think the duplication bugs have been fixed by frame delaying the unit (in addition to group) copy/pasting. |
|
@PabstMirror This worked on my laptop, however now when I try to use it on my desktop it's duplicating every unit. @jonpas you may want to hold off on approving this. Edit: Picture of issue https://puu.sh/GxsV6/9607c217c8.png Ok so I just double checked, and can confirm it's working as intended on my laptop install, so there's definitely something fucky going on. I reinstalled the PBO and now its working. No idea what happened but ¯\(ツ)/¯ |
|
Were you using an older version on your desktop, pre-02d09bd? |
|
Pabs sent me the cba_ui pbo on the 22nd, so presumably no. I was also using the same pbo on both machines. |
I mean, this could very well mean you had an older version. |
Co-authored-by: Jo David <github@jonathandavid.de>
When merged this pull request will:
Image