Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider UI style improvements for cba_settings #1231

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

mharis001
Copy link
Contributor

When merged this pull request will:

  • Fix overlap between sliders and their associated edit boxes
  • Use 3DEN controls arrow images for sliders, combo boxes, and scroll bars
    • Somewhat subjective which is better but I think the filled arrows look better
Images

Before:
cba_settings_1

After:
cba_settings_2

@commy2
Copy link
Contributor

commy2 commented Sep 15, 2019

For combo menus we change the icons to the 3den icons by creating a new base class GVAR(RscCombo) that inherits from RscCombo.

For sliders we change the base class from RscXSliderH to ctrlXSliderH.

Why?

@mharis001
Copy link
Contributor Author

mharis001 commented Sep 15, 2019

For combo boxes, a new base class is created because we want to keep the font, font size, colors from RscCombo. The 3DEN equivalent base class (ctrlCombo) has significantly different visuals and would look out of place in the UI without tweaking.

I decided it was easier to change the image paths from RscCombo than the fonts/colors from ctrlCombo. Either way, would require a new base class.

For sliders, RscXSliderH and ctrlXSliderH are (for the most part) the same except for the image paths.

Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2
Copy link
Contributor

commy2 commented Sep 15, 2019

Okay, GVAR(RscCombo) is a hybrid with RscCombo text style and ctrlCombo icons, while ctrlXSliderH has no text.

@commy2 commy2 added this to the 3.13 milestone Sep 15, 2019
@commy2 commy2 changed the title Minor improvements to settings UI Slider UI style improvements for cba_settings Sep 15, 2019
@commy2 commy2 merged commit 5cb3ebe into CBATeam:master Sep 17, 2019
@mharis001 mharis001 deleted the settings-ui-changes branch September 17, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants