Add support for 21:9 resolutions to CBA optics addon #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he sides to support 21:9 aspect ratio screens.
|
Per request from @commy2 I tried to match up the camera FOV with your unscoped FOV which should result in objects staying in the same place they when unscoped while scoped in using the PIP camera. picsUnscoped: |
…h what you saw before scoping in. See #1245 (comment) for comparison of old value.
|
With 21:9 the FOV is too wide but I don't know if we want to mess with scaling based on resolution/aspect ratio right now? picsUnscoped: |
…sues with increasing this value.
commy2
approved these changes
Oct 26, 2019
jonpas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I did some tests by starting the virtual arsenal mission and running
player setPosASL [4229.13,4221.35,5.00144]; player setDir 125.176;then bringing up the CBA optic and snapping a pic to compare differences after making changes to the model and camera fov.pics
Before on 16:9
After on 16:9
Before on 21:9
After on 21:9
