Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize XEH and Versioning logging prefixs #1267

Merged
merged 5 commits into from
Dec 21, 2019
Merged

Standardize XEH and Versioning logging prefixs #1267

merged 5 commits into from
Dec 21, 2019

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Dec 20, 2019

before

XEH: missionNamespace processed [false]
[CBA] (settings) INFO: Checking mission settings file ...
[3876,80.609,0,"XEH: PreInit started. v3.13.0.191116"]
[CBA] (settings) INFO: Reading settings from settings file.
[3878,81.513,0,"XEH: PostInit started. MISSIONINIT: missionName=tempMissionSP, missionVersion=53, worldName=Stratis, isMultiplayer=false, isServer=true, isDedicated=false, CBA_isHeadlessClient=false, hasInterface=true, didJIP=false"]
[3878,81.528,0,"CBA_VERSIONING: cba=3.13.0.191116, ace=3.12.6.43, acex=3.4.2.13, "]
[3878,81.919,0,"XEH: PostInit finished."]
[CBA] (optics) INFO: Scripted camera restarted.

after

[CBA] (XEH): missionNamespace processed [false]
[CBA] (XEH) [1998,49.636,0] PreInit started. v3.13.0.191116
[CBA] (settings) INFO: Reading settings from settings file.
[CBA] (settings) INFO: Finished reading settings from settings file.
[CBA] (XEH) [1998,50.153,0] PreInit finished.
[CBA] (XEH) [2000,50.587,0] PostInit started. MISSIONINIT: missionName=tempMissionSP, missionVersion=53, worldName=Stratis, isMultiplayer=false, isServer=true, isDedicated=false, CBA_isHeadlessClient=false, hasInterface=true, didJIP=false
[CBA] (versioning) [2000,50.602,0] cba=3.13.0.191116, ace=3.12.6.43, acex=3.4.2.13
[CBA] (XEH) [2000,50.996,0] PostInit finished.
[CBA] (optics) INFO: Scripted camera restarted.

Makes logging consistent with other CBA
Some people may not know that XEH means CBA
(although most who know how to open a RPT probably do)

@PabstMirror PabstMirror added this to the 3.13.1 milestone Dec 20, 2019
@jonpas jonpas requested a review from commy2 December 20, 2019 02:09
@commy2
Copy link
Contributor

commy2 commented Dec 20, 2019

@PabstMirror
Copy link
Contributor Author

I think that needs DEBUG_SYNCHRONOUS

@commy2
Copy link
Contributor

commy2 commented Dec 20, 2019

Then define DEBUG_SYNCHRONOUS (should be already for xeh component).
There is no reason not to.

@commy2 commy2 modified the milestones: 3.13.1, 3.14 Dec 20, 2019
@commy2 commy2 changed the title Standerdize XEH and Versioning logging prefixs Standardize XEH and Versioning logging prefixs Dec 21, 2019
@commy2 commy2 merged commit 80a6155 into master Dec 21, 2019
@commy2 commy2 deleted the xehVerLoggin branch December 21, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants