Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore selected tab in settings ui #1281

Merged
merged 2 commits into from
Jan 18, 2020
Merged

restore selected tab in settings ui #1281

merged 2 commits into from
Jan 18, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jan 12, 2020

When merged this pull request will:

  • make the settings UI remember which tab (SERVER/MISSION/CLIENT) you selected previously when reopening the UI.

@commy2 commy2 added this to the 3.14 milestone Jan 12, 2020
@jonpas
Copy link
Member

jonpas commented Jan 12, 2020

What happens if previously selected tab isn't available (eg. no Server in Eden)?

@commy2
Copy link
Contributor Author

commy2 commented Jan 12, 2020 •
edited
Loading

-_-
nvm

@commy2 commy2 added the WIP label Jan 12, 2020
@commy2 commy2 removed the WIP label Jan 12, 2020
@commy2 commy2 merged commit 1de2088 into master Jan 18, 2020
@commy2 commy2 deleted the keepLastSelection_settings branch January 18, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @jonpas