Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize player events #1289

Merged
merged 15 commits into from
Feb 7, 2020
Merged

optimize player events #1289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
152a53f
optimize playerEvents
commy2 Feb 1, 2020
1bd0ffd
optimizations for the common case
commy2 Feb 2, 2020
437fc99
optimizations, missing private fix
commy2 Feb 2, 2020
8045584
simplify a check
commy2 Feb 2, 2020
2b2c3ae
simplify a check
commy2 Feb 2, 2020
4ae6fdc
pass old and new states as arguments
commy2 Feb 2, 2020
9b57e86
raise muzzle and weaponMode events on weapon and muzzle switch respec…
commy2 Feb 2, 2020
17c4ecd
Update addons/events/fnc_addPlayerEventHandler.sqf
commy2 Feb 2, 2020
836ccbb
an optimization by dedmen
commy2 Feb 4, 2020
73b7eb2
Merge branch 'master' of https://github.com/CBATeam/CBA_A3 into playe…
commy2 Feb 4, 2020
8cb68c7
offload each frame function to own script file
commy2 Feb 4, 2020
20ede7b
offload each frame function to own script file
commy2 Feb 5, 2020
a286f8c
fix the name in the header
commy2 Feb 5, 2020
b32b5d5
fix some things, add turretWeapon event
commy2 Feb 6, 2020
0c26986
fix some things, add turretWeapon event
commy2 Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 97 additions & 77 deletions addons/events/fnc_addPlayerEventHandler.sqf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Description:
Possible events:
"unit" - player controlled unit changed
"weapon" - currently selected weapon change
"muzzle" - currently selected muzzle change
"weaponMode" - currently selected weapon mode change
"loadout" - players loadout changed
"vehicle" - players current vehicle changed
"turret" - position in vehicle changed
Expand Down Expand Up @@ -55,6 +57,18 @@ private _id = switch (_type) do {
};
[QGVAR(weaponEvent), _function] call CBA_fnc_addEventHandler // return id
};
case "muzzle": {
if (_applyRetroactively && {!isNull (missionNamespace getVariable [QGVAR(oldUnit), objNull])}) then {
[GVAR(oldUnit), currentMuzzle GVAR(oldUnit)] call _function;
};
[QGVAR(muzzleEvent), _function] call CBA_fnc_addEventHandler // return id
};
case "weaponmode": {
if (_applyRetroactively && {!isNull (missionNamespace getVariable [QGVAR(oldUnit), objNull])}) then {
[GVAR(oldUnit), currentWeaponMode GVAR(oldUnit)] call _function;
};
[QGVAR(weaponModeEvent), _function] call CBA_fnc_addEventHandler // return id
};
case "loadout": {
if (_applyRetroactively && {!isNull (missionNamespace getVariable [QGVAR(oldUnit), objNull])}) then {
[GVAR(oldUnit), getUnitLoadout GVAR(oldUnit)] call _function;
Expand Down Expand Up @@ -121,115 +135,121 @@ if (_id != -1) then {
GVAR(oldGroup) = grpNull;
GVAR(oldLeader) = objNull;
GVAR(oldWeapon) = "";
GVAR(oldMuzzle) = "";
GVAR(oldWeaponMode) = "";
GVAR(oldLoadout) = [];
GVAR(oldLoadoutNoAmmo) = [];
GVAR(oldVehicle) = objNull;
GVAR(inVehicle) = false;
GVAR(oldTurret) = [];
GVAR(oldVisionMode) = -1;
GVAR(oldCameraView) = "";
GVAR(oldFeatureCamera) = "";
GVAR(oldVisibleMap) = false;
GVAR(oldUAVControl) = [];
GVAR(controlledEntity) = objNull;
GVAR(oldState) = [];

GVAR(playerEHInfo) pushBack addMissionEventHandler ["EachFrame", {call FUNC(playerEH_EachFrame)}];
[QFUNC(playerEH_EachFrame), {
commy2 marked this conversation as resolved.
Show resolved Hide resolved
SCRIPT(playerEH_EachFrame);
private _player = missionNamespace getVariable ["bis_fnc_moduleRemoteControl_unit", player];
if !(_player isEqualTo GVAR(oldUnit)) then {
[QGVAR(unitEvent), [_player, GVAR(oldUnit)]] call CBA_fnc_localEvent;
GVAR(oldUnit) = _player;
GVAR(oldUAVControl) = []; // force update
};

private _data = group _player;
if !(_data isEqualTo GVAR(oldGroup)) then {
[QGVAR(groupEvent), [_player, GVAR(oldGroup)]] call CBA_fnc_localEvent;
GVAR(oldGroup) = _data;
};
private _unit = missionNamespace getVariable ["bis_fnc_moduleRemoteControl_unit", player];
private _controlledEntity = _unit;

_data = leader _player;
if !(_data isEqualTo GVAR(oldLeader)) then {
[QGVAR(leaderEvent), [_player, GVAR(oldLeader)]] call CBA_fnc_localEvent;
GVAR(oldLeader) = _data;
private _uavControl = UAVControl getConnectedUAV _unit;
commy2 marked this conversation as resolved.
Show resolved Hide resolved
_uavControl = _uavControl param [(_uavControl find _unit) + 1, ""];
if (_uavControl isEqualTo "DRIVER") then {
_controlledEntity = driver getConnectedUAV _unit;
};

_data = currentWeapon _player;
if !(_data isEqualTo GVAR(oldWeapon)) then {
GVAR(oldWeapon) = _data;
[QGVAR(weaponEvent), [_player, _data]] call CBA_fnc_localEvent;
if (_uavControl isEqualTo "GUNNER") then {
_controlledEntity = gunner getConnectedUAV _unit;
};

_data = getUnitLoadout _player;
if !(_data isEqualTo GVAR(oldLoadout)) then {
GVAR(oldLoadout) = _data;
private _state = [
_unit, group _unit, leader _unit,
currentWeapon _unit, currentMuzzle _unit, currentWeaponMode _unit,
getUnitLoadout _unit,
vehicle _unit, _unit call CBA_fnc_turretPath,
commy2 marked this conversation as resolved.
Show resolved Hide resolved
currentVisionMode _controlledEntity, cameraView
];

if !(_state isEqualTo GVAR(oldState)) then {
GVAR(oldState) = _state;

_state params [
"_newunit", "_newGroup", "_newLeader",
"_newWeapon", "_newMuzzle", "_newWeaponMode",
"_newLoadout", "_newVehicle", "_newTurret",
"_newVisionMode", "_newCameraView"
];

if !(_newunit isEqualTo GVAR(oldUnit)) then {
[QGVAR(unitEvent), [_unit, GVAR(oldUnit)]] call CBA_fnc_localEvent;
GVAR(oldUnit) = _unit;
};

// we don't want to trigger this just because your ammo counter decreased.
_data = + GVAR(oldLoadout);
if !(_newGroup isEqualTo GVAR(oldGroup)) then {
[QGVAR(groupEvent), [_unit, GVAR(oldGroup)]] call CBA_fnc_localEvent;
GVAR(oldGroup) = _newGroup;
};

{
private _weaponInfo = _data param [_forEachIndex, []];
if !(_weaponInfo isEqualTo []) then {
_weaponInfo set [4, _x];
_weaponInfo deleteAt 5;
};
} forEach [primaryWeaponMagazine _player, secondaryWeaponMagazine _player, handgunMagazine _player];
if !(_newLeader isEqualTo GVAR(oldLeader)) then {
[QGVAR(leaderEvent), [_unit, GVAR(oldLeader)]] call CBA_fnc_localEvent;
GVAR(oldLeader) = _newLeader;
};

if !(_data isEqualTo GVAR(oldLoadoutNoAmmo)) then {
GVAR(oldLoadoutNoAmmo) = _data;
[QGVAR(loadoutEvent), [_player, GVAR(oldLoadout)]] call CBA_fnc_localEvent;
if !(_newWeapon isEqualTo GVAR(oldWeapon)) then {
[QGVAR(weaponEvent), [_unit, _newWeapon]] call CBA_fnc_localEvent;
GVAR(oldWeapon) = _newWeapon;
};
};

_data = vehicle _player;
if !(_data isEqualTo GVAR(oldVehicle)) then {
GVAR(oldVehicle) = _data;
[QGVAR(vehicleEvent), [_player, _data]] call CBA_fnc_localEvent;
GVAR(inVehicle) = _data != _player;
if (!GVAR(inVehicle)) then {
_data = _player call CBA_fnc_turretPath;
if !(_data isEqualTo GVAR(oldTurret)) then {
GVAR(oldTurret) = _data;
[QGVAR(turretEvent), [_player, _data]] call CBA_fnc_localEvent;
};
if !(_newMuzzle isEqualTo GVAR(oldMuzzle)) then {
[QGVAR(muzzleEvent), [_unit, _newMuzzle]] call CBA_fnc_localEvent;
GVAR(oldMuzzle) = _newMuzzle;
};
};
if (GVAR(inVehicle)) then {
_data = _player call CBA_fnc_turretPath;
if !(_data isEqualTo GVAR(oldTurret)) then {
GVAR(oldTurret) = _data;
[QGVAR(turretEvent), [_player, _data]] call CBA_fnc_localEvent;

if !(_newWeaponMode isEqualTo GVAR(oldWeaponMode)) then {
[QGVAR(weaponModeEvent), [_unit, _newWeaponMode]] call CBA_fnc_localEvent;
GVAR(oldWeaponMode) = _newWeaponMode;
};
};

// handle controlling UAV, UAV entity needed for visionMode
_data = UAVControl getConnectedUAV _player;
if !(_data isEqualTo GVAR(oldUAVControl)) then {
GVAR(oldUAVControl) = _data;
if !(_newLoadout isEqualTo GVAR(oldLoadout)) then {
// We don't want to trigger this just because your ammo counter decreased.
_newLoadoutNoAmmo = + _newLoadout;

{
private _weaponInfo = _newLoadoutNoAmmo param [_forEachIndex, []];
if !(_weaponInfo isEqualTo []) then {
_weaponInfo set [4, _x];
_weaponInfo deleteAt 5;
};
} forEach [primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit];

if !(_newLoadoutNoAmmo isEqualTo GVAR(oldLoadoutNoAmmo)) then {
[QGVAR(loadoutEvent), [_unit, GVAR(oldLoadout)]] call CBA_fnc_localEvent;
GVAR(oldLoadoutNoAmmo) = _newLoadoutNoAmmo;
};

private _role = _data param [(_data find _player) + 1, ""];
if (_role isEqualTo "DRIVER") exitWith {
GVAR(controlledEntity) = driver getConnectedUAV _player;
GVAR(oldLoadout) = _newLoadout;
};

if (_role isEqualTo "GUNNER") exitWith {
GVAR(controlledEntity) = gunner getConnectedUAV _player;
if !(_newVehicle isEqualTo GVAR(oldVehicle)) then {
[QGVAR(vehicleEvent), [_unit, _newVehicle]] call CBA_fnc_localEvent;
GVAR(oldVehicle) = _newVehicle;
};

GVAR(controlledEntity) = _player;
};
if !(_newTurret isEqualTo GVAR(oldTurret)) then {
[QGVAR(turretEvent), [_unit, _newTurret]] call CBA_fnc_localEvent;
GVAR(oldTurret) = _newTurret;
};

_data = currentVisionMode GVAR(controlledEntity);
if !(_data isEqualTo GVAR(oldVisionMode)) then {
GVAR(oldVisionMode) = _data;
[QGVAR(visionModeEvent), [_player, _data]] call CBA_fnc_localEvent;
};
if !(_newVisionMode isEqualTo GVAR(oldVisionMode)) then {
[QGVAR(visionModeEvent), [_unit, _newVisionMode]] call CBA_fnc_localEvent;
GVAR(oldVisionMode) = _newVisionMode;
};

_data = cameraView;
if !(_data isEqualTo GVAR(oldCameraView)) then {
GVAR(oldCameraView) = _data;
[QGVAR(cameraViewEvent), [_player, _data]] call CBA_fnc_localEvent;
if !(_newCameraView isEqualTo GVAR(oldCameraView)) then {
[QGVAR(cameraViewEvent), [_unit, _newCameraView]] call CBA_fnc_localEvent;
GVAR(oldCameraView) = _newCameraView;
};
};
}] call CBA_fnc_compileFinal;

Expand Down
6 changes: 6 additions & 0 deletions addons/events/fnc_removePlayerEventHandler.sqf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ switch (_type) do {
case "weapon": {
[QGVAR(weaponEvent), _id] call CBA_fnc_removeEventHandler;
};
case "muzzle": {
[QGVAR(muzzleEvent), _id] call CBA_fnc_removeEventHandler;
};
case "weaponmode": {
[QGVAR(weaponModeEvent), _id] call CBA_fnc_removeEventHandler;
};
case "loadout": {
[QGVAR(loadoutEvent), _id] call CBA_fnc_removeEventHandler;
};
Expand Down