Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Add support for percentage sliders #1290

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

mharis001
Copy link
Contributor

When merged this pull request will:

  • Allow sliders to be specified as "percentage sliders"
    • For example, if the range is 0 to 1, displayed value will be formatted to 0 to 100 and have a percent sign - users will also input edit box values between 0 and 100
  • Increase width of controls to allow for all of "100%" to fit in the edit box

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked the control size and position changes, but skimming through the ACE settings should show any discrepancies.

@commy2 commy2 added this to the 3.13.1 milestone Feb 4, 2020
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side, just make sure to check for discrepancies in ACE.

@commy2 commy2 merged commit 9e40cec into CBATeam:master Feb 7, 2020
@mharis001 mharis001 deleted the settings-percentage-slider branch February 7, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants