Return target exec result back to executor #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
reviewed
Mar 1, 2020
| @@ -13,7 +13,10 @@ Author: | |||
| commy2 | |||
| ---------------------------------------------------------------------------- */ | |||
|
|
|||
| #define COUNT_WATCH_BOXES 8 | |||
| #define COUNT_WATCH_BOXES 8 | |||
| #define EXEC_RESULT ([nil] apply {[] call _this} param [0, text ""]) | |||
There was a problem hiding this comment.
The watch fields report #NIL for nil return value and I like that you can see that something happened instead of void.
Vanilla reports:
nil ->
[nil] -> [<any>]
So it only works for array elements there, but we can be better than that.
I'd wish for text "<any>" as default value, and also the same for the watch fields (could be part of this PR).
There was a problem hiding this comment.
Also, don't do this multiple spaces inside a line formatting. Should there ever be another macro added with a longer name, all the other spacing will have to be adjusted resulting in a pink wall. Don't do that.
dedmen
reviewed
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: