Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createPerFrameHandlerObject - remove pfeh if location deleted #1306

Merged
merged 2 commits into from
Mar 13, 2020
Merged

createPerFrameHandlerObject - remove pfeh if location deleted #1306

merged 2 commits into from
Mar 13, 2020

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Mar 12, 2020 •
edited
Loading

If location doesn't exist, then you won't get a valid getVar from it

x = [{systemChat str time}, 1] call CBA_fnc_createPerFrameHandlerObject

deleteLocation x

count cba_common_perFrameHandlerArray does not decrease

Edit: This would be a rare bug, CBA_fnc_deletePerFrameHandlerObject was safe

@commy2 commy2 added this to the 3.15 milestone Mar 12, 2020
@commy2 commy2 self-assigned this Mar 12, 2020
@commy2 commy2 added the Bug Fix label Mar 12, 2020
@PabstMirror @commy2
Update addons/common/fnc_createPerFrameHandlerObject.sqf
686ca7c 
Co-Authored-By: commy2 <commy-2@gmx.de>
@commy2 commy2 merged commit 0a83503 into master Mar 13, 2020
@commy2 commy2 deleted the nullLocationsTellNoTales branch March 13, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees

@commy2 commy2

Labels
Bug Fix
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PabstMirror @commy2