Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CBA_fnc_formatNumber for small negative numbers #1309

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Fix CBA_fnc_formatNumber for small negative numbers #1309

merged 2 commits into from
Mar 16, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 14, 2020

When merged this pull request will:

  • Before:
[-0.001, 1, 2] call CBA_fnc_formatNumber // "-0.00"
  • After:
[-0.001, 1, 2] call CBA_fnc_formatNumber // "0.00"

Doesn't make sense to have it report a negative number if all decimal places are zeros.

@commy2 commy2 added the Bug Fix label Mar 14, 2020
@commy2 commy2 added this to the 3.15 milestone Mar 14, 2020
@commy2 commy2 changed the title Fix format number Fix CBA_fnc_formatNumber for small negative numbers Mar 14, 2020
@commy2 commy2 merged commit 8757f91 into master Mar 16, 2020
@commy2 commy2 deleted the fixFormatNumber branch March 16, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @jonpas