Added 4 New Array Functions #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the "find" script command finds the first array element or string-within-string, these function names could perhaps be shortened somewhat. Also, "empty" in BIS scripting parlance is "nil". How about calling them
I love the included unit tests! |
|
I like @Killswitch00's names a lot more. They're very similar, to the point and short to type. |
|
is everything fine? |
|
The unit tests are missing and the added unit test file could be renamed to, say, "test_find.sqf". |
add some error handling add Test Script
|
my question is did i need a test function? or not |
| _fn = "CBA_fnc_findTypOf"; | ||
| LOG("Testing " + _fn); | ||
|
|
||
| TEST_DEFINED("CBA_fnc_findTypOf",""); |
There was a problem hiding this comment.
I can see that this unit test file hasn't been tested at all. Run it using
[] call compile preprocessFileLineNumbers "\x\cba\addons\arrays\test_find.sqf";
Improvements, fixes and tests for new array functions
|
|
||
| TEST_DEFINED("CBA_fnc_findNil",""); | ||
|
|
||
| // Use of embeded nil |
|
|
||
| Parameters: | ||
| 0: Array | ||
| 1: TypeName, if parameter is a string, that contains a case insensitive typename, it will be used. Otherwies typename of the variable will be used. |
More typo fixes
|
|
||
| if (isNil "_typeName" || {_array isEqualTo []}) exitWith {-1}; | ||
|
|
||
| // If a string is given, tansform to uppercase for type matching |
There was a problem hiding this comment.
A better word for "transform" in this context is to use "convert"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 New Array Functions to Find First Entry of TypeOf, TypeName, Null or Nil in Array