Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEH - Update configs for 1.98 (Oldman) #1311

Merged
merged 1 commit into from
Apr 14, 2020
Merged

XEH - Update configs for 1.98 (Oldman) #1311

merged 1 commit into from
Apr 14, 2020

Conversation

PabstMirror
Copy link
Contributor

For current RC (make sure to test after final release)

[CBA] (xeh) WARNING: O_UAV_01_Mine_F does not support Extended Event Handlers! Addon: expansion
[CBA] (xeh) WARNING: Land_MapBoard_01_Wall_Syndikat_Tanoa_F does not support Extended Event Handlers! Addon: expansion
[CBA] (xeh) WARNING: Land_MapBoard_01_Tripod_Syndikat_Tanoa_F does not support Extended Event Handlers! Addon: expansion
[CBA] (xeh) WARNING: Land_MapBoard_01_Map_Syndikat_Tanoa_F does not support Extended Event Handlers! Addon: expansion

@commy2
Copy link
Contributor

commy2 commented Mar 26, 2020

Is this bad if merged now? It may create duplicate classes if it inherits from something public (which this all seems to).

@commy2 commy2 added Task and removed Bug Fix labels Mar 26, 2020
@commy2 commy2 added this to the 3.15.1 milestone Mar 26, 2020
@PabstMirror
Copy link
Contributor Author

I think the base classes are all scope=1
so it should be fine, I can remove the 1.98 specific stuff

@PabstMirror
Copy link
Contributor Author

but I also remember XEH stuff changing between RC and release, so it might be better to hold off

@commy2
Copy link
Contributor

commy2 commented Mar 26, 2020 •
edited
Loading

I'd say we ignore it for now and release it as update (3.15.1?) once Oldman is out.

@jonpas

This comment has been minimized.

Sign in to view
@PabstMirror
Copy link
Contributor Author

Ready to go, final seems same as RC

@PabstMirror PabstMirror merged commit b2bac30 into master Apr 14, 2020
@PabstMirror PabstMirror deleted the oldmanXEH branch April 14, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PabstMirror @commy2 @jonpas @bux