Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory - Add context menu options for pointers and optics #1328

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Apr 25, 2020

When merged this pull request will:

  • title

https://i.imgur.com/1X6U2Xq.mp4

@veteran29 veteran29 added this to the 3.15.2 milestone Apr 25, 2020
@commy2
Copy link
Contributor

commy2 commented Apr 25, 2020

https://i.imgur.com/FtfUJdi.png

Appears to work.

@commy2
Copy link
Contributor

commy2 commented Apr 25, 2020

This branch has not been deployed

@jonpas jonpas changed the title Add inventory context menu options for pointers and optics Inventory - Add context menu options for pointers and optics Apr 25, 2020
@jonpas jonpas merged commit a0ecff5 into master Apr 25, 2020
@jonpas jonpas deleted the accessories-context-menu branch April 25, 2020 19:19
@dedmen
Copy link
Contributor

dedmen commented Apr 26, 2020

How about "next state" instead just add a action for each specific state?

@veteran29
Copy link
Member Author

I don't understand. Can you elaborate?

@PabstMirror
Copy link
Contributor

PabstMirror commented Apr 26, 2020

edit: I think this is what dead means
If an attachment can be 4 different things [light, IR laser, green laser, red laser]
then list all possibilities, instead of "next/previous"

@dedmen
Copy link
Contributor

dedmen commented Apr 27, 2020

Yes that.
Instead of just "Next State"
"Switch to Red Laser"

But we don't have nested context menu? So fear is that it might clutter the menu with too many entries?

@jonpas
Copy link
Member

jonpas commented Apr 27, 2020

But we don't have nested context menu? So fear is that it might clutter the menu with too many entries?

It might for attachments with many states, but less so if only available once attached.

@veteran29
Copy link
Member Author

Feel free to do another PR then. I think it's just fluff, attachments rarely have more than 3 states, you can click through them really quickly as the menu is set to not close automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants