Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposable - Reduce savegame file size #1334

Merged
merged 1 commit into from
May 9, 2020
Merged

Disposable - Reduce savegame file size #1334

merged 1 commit into from
May 9, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 9, 2020

When merged this pull request will:

  • This saves about 32 kilobytes per object in a savegame according to dedmen at the cost of neglible overhead on object creation.

@commy2 commy2 added this to the 3.15.2 milestone May 9, 2020
@PabstMirror PabstMirror changed the title [Disposable] Reduce savegame file size Disposable - Reduce savegame file size May 9, 2020
jonpas
jonpas reviewed May 9, 2020
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment on the reasoning.

@commy2 commy2 merged commit 5c478a0 into master May 9, 2020
@commy2 commy2 deleted the disposable-savegames branch May 9, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @jonpas @PabstMirror