Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI - Put Invisible Target Soldier String Key Into CBA #1393

Merged
merged 2 commits into from
Dec 17, 2020
Merged

AI - Put Invisible Target Soldier String Key Into CBA #1393

merged 2 commits into from
Dec 17, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Nov 20, 2020

When merged this pull request will:

  • The translation already is in the base game and used on these objects by inheritance.
  • Therefore all these translations are presumed to be correct.
  • This allows translators to change the names to fix the lexicographic order of this object with the other two targets (e.g. French)

@commy2 commy2 added this to the 3.16 milestone Nov 20, 2020
@commy2 commy2 force-pushed the invisible-target-soldier-string-key branch from fa0482f to f49f94c Compare November 20, 2020 19:03
@commy2 commy2 force-pushed the invisible-target-soldier-string-key branch from f49f94c to 5f0a522 Compare November 20, 2020 19:04
Elgin675
Elgin675 suggested changes Nov 20, 2020
View reviewed changes
addons/ai/stringtable.xml Outdated Show resolved Hide resolved
@commy2 @Elgin675
Translation In Lexicographic Order For French Invisible Target Soldier
df63a0d 
Co-authored-by: Elgin675 <elgin675@hotmail.com>
@commy2 commy2 merged commit d840116 into master Dec 17, 2020
@commy2 commy2 deleted the invisible-target-soldier-string-key branch December 17, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elgin675 Elgin675 Elgin675 requested changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Enhancement Translation
Projects
None yet
Milestone
3.15.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @PabstMirror @Elgin675